hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 10:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

[zlaski/pointer-overflow-check] Improve test case.

Browse Source
This commit is contained in:
Ziemowit Laski
2019-11-05 13:00:55 -08:00
parent 3aafcf4604
commit 0df3d2ce60
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cpp/ql/test/query-tests/Likely Bugs/Memory Management/PointerOverflowCheck/test.cpp
View File

@@ -9,7 +9,7 @@ bool check_pointer_overflow(P *ptr, P *ptr_end) {
// x86-64 gcc 9.2 -O2: not deleted
// x86-64 clang 9.0.0 -O2: not deleted
// x64 msvc v19.22 /O2: not deleted
return ptr + 4 >= ptr_end; // GOOD
return ptr_end - ptr > 4; // GOOD
}
struct Q {
@@ -22,6 +22,6 @@ struct Q {
void foo(int untrusted_int) {
Q q;
if (q.begin() + untrusted_int > q.end() || // GOOD
q.begin() + untrusted_int < q.begin()) // BAD
q.begin() + untrusted_int < q.begin()) // BAD [NOT DETECTED]
throw q;
}