hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-17 21:14:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
Tom Hvitved
2026-04-07 11:38:48 +02:00
parent 1e1a8732a3
commit 0d4524f8f3
4 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shared/dataflow/codeql/dataflow/DataFlow.qll
View File

@@ -64,7 +64,7 @@ signature module InputSig<LocationSig Location> {
DataFlowType getNodeType(Node node);
/**
* Gets a special type to use for parameter nodes belonging to callables with a
* Gets a special type to use for parameter node `p` belonging to callables with a
* source node where a source call context `FlowFeature` is used, if any.
*
* This can be used to prevent lambdas from being resolved, when a concrete call
@@ -90,7 +90,7 @@ signature module InputSig<LocationSig Location> {
* prevent the call edge from (1) to (4). Note that the call edge from (3) to (2)
* will still be valid.
*/
default DataFlowType getSourceContextParameterNodeType() { none() }
default DataFlowType getSourceContextParameterNodeType(Node p) { none() }
predicate nodeIsHidden(Node node);

4
shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll
View File

@@ -2117,8 +2117,8 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
private predicate typeFlowParamType(ParamNode p, Type t, boolean cc) {
exists(Callable c |
Input::dataFlowNonCallEntry(c, cc) and
if cc = true and exists(getSourceContextParameterNodeType())
then t = getSourceContextParameterNodeType()
if cc = true and exists(getSourceContextParameterNodeType(p))
then t = getSourceContextParameterNodeType(p)
else trackedParamWithType(p, t, c)
)
or