hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 18:56:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: remove false negative comments in swap tests

Browse Source
This commit is contained in:
Robert Marsh
2020-06-16 11:33:26 -07:00
parent 1c9b6f0a48
commit 0c99b3644c
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cpp/ql/test/library-tests/dataflow/taint-tests/swap1.cpp
View File

@@ -62,7 +62,7 @@ void test_copy_assignment_operator()
y = x; y = x;
sink(y.data1); // tainted [FALSE NEGATIVE in IR] sink(y.data1); // tainted
sink(x.data1); // tainted sink(x.data1); // tainted
IntWrapper::Class z1, z2; IntWrapper::Class z1, z2;
@@ -86,7 +86,7 @@ void test_move_assignment_operator()
y = std::move(x); y = std::move(x);
sink(y.data1); // tainted [FALSE NEGATIVE in IR] sink(y.data1); // tainted
sink(x.data1); // tainted sink(x.data1); // tainted
} }
@@ -99,5 +99,5 @@ void test_move_constructor()
IntWrapper::Class move_to(std::move(move_from)); IntWrapper::Class move_to(std::move(move_from));
sink(move_to.data1); // tainted [FALSE NEGATIVE in IR] sink(move_to.data1); // tainted
} }

6
cpp/ql/test/library-tests/dataflow/taint-tests/swap2.cpp
View File

@@ -62,7 +62,7 @@ void test_copy_assignment_operator()
y = x; y = x;
sink(y.data1); // tainted [FALSE NEGATIVE in IR] sink(y.data1); // tainted
sink(x.data1); // tainted sink(x.data1); // tainted
IntWrapper::Class z1, z2; IntWrapper::Class z1, z2;
@@ -86,7 +86,7 @@ void test_move_assignment_operator()
y = std::move(x); y = std::move(x);
sink(y.data1); // tainted [FALSE NEGATIVE in IR] sink(y.data1); // tainted
sink(x.data1); // tainted sink(x.data1); // tainted
} }
@@ -99,5 +99,5 @@ void test_move_constructor()
IntWrapper::Class move_to(std::move(move_from)); IntWrapper::Class move_to(std::move(move_from));
sink(move_to.data1); // tainted [FALSE NEGATIVE in IR] sink(move_to.data1); // tainted
} }