hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 12:15:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Rename SystemFunction and restore QLDoc

Browse Source
This commit is contained in:
Robert Marsh
2021-09-22 14:22:57 -07:00
parent 6f03c3e252
commit 0c5d642489
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cpp/ql/lib/semmle/code/cpp/security/CommandExecution.qll
View File

@@ -6,7 +6,10 @@ import semmle.code.cpp.models.interfaces.SideEffect
import semmle.code.cpp.models.interfaces.Alias
import semmle.code.cpp.models.interfaces.CommandExecution
class WrappedSystemFunction extends FunctionWithWrappers instanceof CommandExecutionFunction {
/**
* A function for running a command using a command interpreter.
*/
class SystemFunction extends FunctionWithWrappers instanceof CommandExecutionFunction {
override predicate interestingArg(int arg) {
exists(FunctionInput input |
this.(CommandExecutionFunction).hasCommandArgument(input) and
@@ -160,7 +163,7 @@ predicate shellCommandPreface(string cmd, string flag) {
*/
predicate shellCommand(Expr command, string callChain) {
// A call to a function like system()
exists(WrappedSystemFunction systemFunction |
exists(SystemFunction systemFunction |
systemFunction.outermostWrapperFunctionCall(command, callChain)
)
or