From 0c3daabc512c5607c97fd28f7b23bdb35b6e2d56 Mon Sep 17 00:00:00 2001 From: Aditya Sharad Date: Thu, 9 Dec 2021 13:42:33 -0800 Subject: [PATCH] JS: Fix broken regex matching predicate The receiver string and the regex were in the wrong order, leading to test failures when looking for matching comments. --- .../lib/semmle/javascript/dependencies/FrameworkLibraries.qll | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/ql/lib/semmle/javascript/dependencies/FrameworkLibraries.qll b/javascript/ql/lib/semmle/javascript/dependencies/FrameworkLibraries.qll index 9cb4d68fbbf..f6a59c6ed30 100644 --- a/javascript/ql/lib/semmle/javascript/dependencies/FrameworkLibraries.qll +++ b/javascript/ql/lib/semmle/javascript/dependencies/FrameworkLibraries.qll @@ -238,7 +238,7 @@ private class MarkerComment extends Comment { * with version number `version`. */ predicate matchesFramework(FrameworkLibraryWithMarkerComment fl, string version) { - fl.getAMarkerCommentRegexWithoutPlaceholders().regexpCapture(this.getText(), 1) = version + this.getText().regexpCapture(fl.getAMarkerCommentRegexWithoutPlaceholders(), 1) = version } }