hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make predicate name start with has instead of get

Browse Source
This commit is contained in:
Owen Mansel-Chan
2025-11-28 02:26:14 +00:00
parent 303deab608
commit 0b79087782
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
go/ql/src/experimental/CWE-918/validator.qll
View File

@@ -24,7 +24,7 @@ class FieldWithTags extends FieldDecl {
* For example: the tag `json:"word" binding:"required,alpha"` yields `key: "json", value: "word"` * For example: the tag `json:"word" binding:"required,alpha"` yields `key: "json", value: "word"`
* and `key: "binding" values: "required","alpha"`. * and `key: "binding" values: "required","alpha"`.
*/ */
predicate getTagByKeyValue(string key, string value) { predicate hasTagKeyValue(string key, string value) {
exists(string tag, string key_value, string values | exists(string tag, string key_value, string values |
this.getTag().toString() = tag and this.getTag().toString() = tag and
// Each key_value is like key:"value1,value2" // Each key_value is like key:"value1,value2"
@@ -50,7 +50,7 @@ class AlphanumericStructFieldRead extends DataFlow::Node {
exists(FieldWithTags decl, Field field, string tag | exists(FieldWithTags decl, Field field, string tag |
this = field.getARead() and this = field.getARead() and
field.getDeclaration() = decl.getNameExpr(0) and field.getDeclaration() = decl.getNameExpr(0) and
decl.getTagByKeyValue(key, tag) and decl.hasTagKeyValue(key, tag) and
isAlphanumericValidationKind(tag) isAlphanumericValidationKind(tag)
) )
} }