hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-20 08:53:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

AST: improve type of getDefaultValue

Browse Source
This commit is contained in:
Arthur Baars
2021-02-18 13:43:14 +01:00
parent e42d1ff936
commit 095eb803b3
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ql/src/codeql_ruby/ast/Parameter.qll
View File

@@ -120,9 +120,8 @@ class KeywordParameter extends @keyword_parameter, NamedParameter {
* Gets the default value, i.e. the value assigned to the parameter when one
* is not provided by the caller. If the parameter is mandatory and does not
* have a default value, this predicate has no result.
* TODO: better return type (Expr?)
*/
final AstNode getDefaultValue() { result = range.getDefaultValue() }
final Expr getDefaultValue() { result = range.getDefaultValue() }
/**
* Holds if the parameter is optional. That is, there is a default value that
@@ -148,9 +147,8 @@ class OptionalParameter extends @optional_parameter, NamedParameter {
/**
* Gets the default value, i.e. the value assigned to the parameter when one
* is not provided by the caller.
* TODO: better return type (Expr?)
*/
final AstNode getDefaultValue() { result = range.getDefaultValue() }
final Expr getDefaultValue() { result = range.getDefaultValue() }
}
/**

4
ql/src/codeql_ruby/ast/internal/Parameter.qll
View File

@@ -100,7 +100,7 @@ module KeywordParameter {
result = TLocalVariable(_, _, generated.getName())
}
final Generated::AstNode getDefaultValue() { result = generated.getValue() }
final Expr::Range getDefaultValue() { result = generated.getValue() }
final override string toString() { result = this.getName() }
@@ -116,7 +116,7 @@ module OptionalParameter {
result = TLocalVariable(_, _, generated.getName())
}
final Generated::AstNode getDefaultValue() { result = generated.getValue() }
final Expr::Range getDefaultValue() { result = generated.getValue() }
final override string toString() { result = this.getName() }