hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-23 18:33:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Performance: Fix bad join order in dataflow library

Browse Source
This commit is contained in:
Edoardo Pirovano
2021-06-23 17:40:56 +01:00
parent 653afc8448
commit 0909c9ff22
24 changed files with 144 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl.qll
View File

@@ -1247,7 +1247,8 @@ private module Stage2 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself
@@ -1928,7 +1929,8 @@ private module Stage3 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself
@@ -2683,7 +2685,8 @@ private module Stage4 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself

9
java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl2.qll
View File

@@ -1247,7 +1247,8 @@ private module Stage2 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself
@@ -1928,7 +1929,8 @@ private module Stage3 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself
@@ -2683,7 +2685,8 @@ private module Stage4 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself

9
java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl3.qll
View File

@@ -1247,7 +1247,8 @@ private module Stage2 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself
@@ -1928,7 +1929,8 @@ private module Stage3 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself
@@ -2683,7 +2685,8 @@ private module Stage4 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself

9
java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl4.qll
View File

@@ -1247,7 +1247,8 @@ private module Stage2 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself
@@ -1928,7 +1929,8 @@ private module Stage3 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself
@@ -2683,7 +2685,8 @@ private module Stage4 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself

9
java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl5.qll
View File

@@ -1247,7 +1247,8 @@ private module Stage2 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself
@@ -1928,7 +1929,8 @@ private module Stage3 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself
@@ -2683,7 +2685,8 @@ private module Stage4 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself

9
java/ql/src/semmle/code/java/dataflow/internal/DataFlowImpl6.qll
View File

@@ -1247,7 +1247,8 @@ private module Stage2 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself
@@ -1928,7 +1929,8 @@ private module Stage3 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself
@@ -2683,7 +2685,8 @@ private module Stage4 {
parameterFlow(p, ap, ap0, c, config) and
c = getNodeEnclosingCallable(ret) and
revFlow(ret, true, apSome(_), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), ap0, config) and
fwdFlow(ret, any(CcCall ccc), apSome(ap), pragma[only_bind_into](ap0),
pragma[only_bind_into](config)) and
kind = ret.getKind() and
p.isParameterOf(_, pos) and
// we don't expect a parameter to return stored in itself