From 08ec017e4c0c6e22da2069ef84ea24a308739556 Mon Sep 17 00:00:00 2001 From: Chris Smowton Date: Wed, 8 Jul 2020 15:47:35 +0100 Subject: [PATCH] Cleanup: disjunction -> set literal --- ql/src/experimental/CWE-327/InsecureTLS.ql | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/ql/src/experimental/CWE-327/InsecureTLS.ql b/ql/src/experimental/CWE-327/InsecureTLS.ql index e56c1495106..3f8fa167f2f 100644 --- a/ql/src/experimental/CWE-327/InsecureTLS.ql +++ b/ql/src/experimental/CWE-327/InsecureTLS.ql @@ -90,19 +90,10 @@ class TlsInsecureCipherSuitesFlowConfig extends TaintTracking::Configuration { predicate isSourceValueEntity(DataFlow::Node source, string suiteName) { exists(DataFlow::ValueEntity val | val.hasQualifiedName("crypto/tls", suiteName) and - ( - suiteName = "TLS_RSA_WITH_RC4_128_SHA" - or - suiteName = "TLS_RSA_WITH_AES_128_CBC_SHA256" - or - suiteName = "TLS_ECDHE_ECDSA_WITH_RC4_128_SHA" - or - suiteName = "TLS_ECDHE_RSA_WITH_RC4_128_SHA" - or - suiteName = "TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256" - or - suiteName = "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256" - ) + suiteName = + ["TLS_RSA_WITH_RC4_128_SHA", "TLS_RSA_WITH_AES_128_CBC_SHA256", + "TLS_ECDHE_ECDSA_WITH_RC4_128_SHA", "TLS_ECDHE_RSA_WITH_RC4_128_SHA", + "TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256", "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256"] | source = val.getARead() )