hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 09:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Make CredentialsFunctionName use nameIndicatesSensitiveData

Browse Source 
Someone from JS team needs to verify that this is actually OK.
This commit is contained in:
Rasmus Wriedt Larsen
2021-04-21 11:38:52 +02:00
parent e977d6eb75
commit 08e86fdfe5
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
javascript/ql/src/semmle/javascript/security/SensitiveActions.qll
View File

@@ -129,11 +129,7 @@ abstract class SensitiveDataFunctionName extends SensitiveFunctionName {
class CredentialsFunctionName extends SensitiveDataFunctionName {
SensitiveDataClassification classification;
CredentialsFunctionName() {
// TODO: is it by purpose that we don't check whether `this` does not
// match the regexps in `notSensitive`?
this.regexpMatch(maybeSensitive(classification))
}
CredentialsFunctionName() { nameIndicatesSensitiveData(this, classification) }
override SensitiveDataClassification getClassification() { result = classification }
}