hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Function error doesn't always exit

Browse Source 
The configuration in `DefaultOptions.qll` assumed that a call to any
top-level function named `error` would exit the program. This is not
true.

The assumption was probably about `error(3)`, which is a GNU extension.
It only exits if its first argument it not 0. Furthermore, projects such
as openssh may define their own function named `error` with different
behaviour. Because the GNU `error` function is non-standard, it's
perfectly fine to shadow it with a project-specific definition.

This change removes two FPs from `PointlessComparison.qll` on
https://github.com/openssh/openssh-portable.
This commit is contained in:
Jonas Jensen
2019-02-26 16:18:52 +01:00
parent 86e646beb4
commit 07bd85e9fa
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/test/library-tests/controlflow/exits/exits.expected
View File

@@ -3,7 +3,7 @@
| test.cpp:1:6:1:9 | exit | exit | exits |
| test.cpp:2:6:2:10 | _exit | _exit | exits |
| test.cpp:3:6:3:10 | abort | abort | exits |
| test.cpp:4:6:4:10 | error | error | exits |
| test.cpp:4:6:4:10 | error | error | returns |
| test.cpp:5:6:5:18 | __assert_fail | __assert_fail | exits |
| test.cpp:7:6:7:12 | longjmp | longjmp | exits |
| test.cpp:8:6:8:15 | DoesReturn | DoesReturn | returns |