hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rust: Address PR comments

Browse Source
This commit is contained in:
Simon Friis Vindum
2025-02-04 10:19:04 +01:00
parent fc15c0d3b2
commit 07413315a1
3 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
rust/ql/lib/codeql/rust/dataflow/DataFlow.qll
View File

@@ -19,7 +19,7 @@ module DataFlow {
* The value of a parameter at function entry, viewed as a node in a data * The value of a parameter at function entry, viewed as a node in a data
* flow graph. * flow graph.
*/ */
final class ParameterNode = Node::SourceParameterNode; final class ParameterNode extends Node instanceof Node::SourceParameterNode { }
final class PostUpdateNode = Node::PostUpdateNodePublic; final class PostUpdateNode = Node::PostUpdateNodePublic;

6
rust/ql/src/utils/modelgenerator/internal/CaptureModels.qll
View File

@@ -20,7 +20,9 @@ module ModelGeneratorInput implements ModelGeneratorInputSig<Location, RustDataF
Type getType() { any() } Type getType() { any() }
Callable getEnclosingCallable() { result = super.getEnclosingCallable().asCfgScope() } Callable getEnclosingCallable() {
result = this.(Node::Node).getEnclosingCallable().asCfgScope()
}
} }
private predicate relevant(Function api) { private predicate relevant(Function api) {
@@ -91,7 +93,7 @@ module ModelGeneratorInput implements ModelGeneratorInputSig<Location, RustDataF
} }
Callable returnNodeEnclosingCallable(DataFlow::Node ret) { Callable returnNodeEnclosingCallable(DataFlow::Node ret) {
result = ret.getEnclosingCallable().asCfgScope() result = ret.(Node::Node).getEnclosingCallable().asCfgScope()
} }
predicate isOwnInstanceAccessNode(RustDataFlow::ReturnNode node) { predicate isOwnInstanceAccessNode(RustDataFlow::ReturnNode node) {

2
rust/ql/test/utils-tests/modelgenerator/CaptureSummaryModels.ql
View File

@@ -3,7 +3,7 @@ import utils.modelgenerator.internal.CaptureModels
import utils.test.InlineMadTest import utils.test.InlineMadTest
module InlineMadTestConfig implements InlineMadTestConfigSig { module InlineMadTestConfig implements InlineMadTestConfigSig {
string getCapturedModel(Function c) { result = captureMixedFlow(c, _) } string getCapturedModel(Function c) { result = ContentSensitive::captureFlow(c, _) }
string getKind() { result = "summary" } string getKind() { result = "summary" }
} }