hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 01:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Ruby: Clean up Sinatra modeling

Browse Source
This commit is contained in:
Harry Maclean
2023-03-13 19:25:56 +13:00
parent bfe42a656c
commit 071517c74b
4 changed files with 180 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

99
ruby/ql/test/library-tests/frameworks/sinatra/Sinatra.expected
View File

@@ -1,23 +1,24 @@
routes
| app.rb:1:1:105:3 | MyApp | app.rb:2:3:4:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:6:3:8:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:10:3:13:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:15:3:18:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:20:3:22:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:24:3:26:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:28:3:31:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:33:3:35:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:37:3:42:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:44:3:46:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:48:3:50:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:52:3:54:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:56:3:58:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:60:3:62:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:66:3:68:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:70:3:72:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:74:3:77:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:79:3:82:5 | call to get |
| app.rb:1:1:105:3 | MyApp | app.rb:89:3:92:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:2:3:4:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:6:3:8:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:10:3:13:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:15:3:18:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:20:3:22:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:24:3:26:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:28:3:31:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:33:3:35:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:37:3:42:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:44:3:46:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:48:3:50:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:52:3:54:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:56:3:58:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:60:3:62:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:66:3:68:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:70:3:72:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:74:3:77:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:79:3:82:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:89:3:92:5 | call to get |
| app.rb:1:1:114:3 | MyApp | app.rb:94:3:96:5 | call to get |
params
| app.rb:3:14:3:19 | call to params |
| app.rb:12:5:12:10 | call to params |
@@ -34,9 +35,59 @@ erbSyntheticGlobals
| SinatraErbLocalsHash(library-tests/frameworks/sinatra/views/index.erb,library-tests/frameworks/sinatra/app.rb@76:5:76:36) | views/index.erb:0:0:0:0 | views/index.erb |
filters
| app.rb:84:3:87:5 | call to before | before |
| app.rb:94:3:96:5 | call to after | after |
| app.rb:98:3:100:5 | call to before | before |
| app.rb:102:3:104:5 | call to after | after |
| app.rb:98:3:100:5 | call to after | after |
| app.rb:102:3:104:5 | call to before | before |
| app.rb:106:3:108:5 | call to before | before |
| app.rb:111:3:113:5 | call to after | after |
filterPatterns
| app.rb:98:3:100:5 | call to before | app.rb:98:10:98:23 | "/protected/*" |
| app.rb:102:3:104:5 | call to after | app.rb:102:9:102:23 | "/create/:slug" |
| app.rb:106:3:108:5 | call to before | app.rb:106:10:106:23 | "/protected/*" |
| app.rb:111:3:113:5 | call to after | app.rb:111:9:111:23 | "/create/:slug" |
additionalFlowSteps
| app.rb:85:5:85:9 | [post] self | app.rb:2:22:4:5 | <captured> self |
| app.rb:85:5:85:9 | [post] self | app.rb:10:21:13:5 | <captured> self |
| app.rb:85:5:85:9 | [post] self | app.rb:15:23:18:5 | <captured> self |
| app.rb:85:5:85:9 | [post] self | app.rb:24:26:26:5 | <captured> self |
| app.rb:85:5:85:9 | [post] self | app.rb:37:16:42:5 | <captured> self |
| app.rb:85:5:85:9 | [post] self | app.rb:44:53:46:5 | <captured> self |
| app.rb:85:5:85:9 | [post] self | app.rb:56:32:58:5 | <captured> self |
| app.rb:85:5:85:9 | [post] self | app.rb:60:48:62:5 | <captured> self |
| app.rb:85:5:85:9 | [post] self | app.rb:74:11:77:5 | <captured> self |
| app.rb:85:5:85:9 | [post] self | app.rb:79:11:82:5 | <captured> self |
| app.rb:85:5:85:9 | [post] self | app.rb:89:16:92:5 | <captured> self |
| app.rb:85:5:85:9 | [post] self | app.rb:94:15:96:5 | <captured> self |
| app.rb:86:5:86:11 | [post] self | app.rb:2:22:4:5 | <captured> self |
| app.rb:86:5:86:11 | [post] self | app.rb:10:21:13:5 | <captured> self |
| app.rb:86:5:86:11 | [post] self | app.rb:15:23:18:5 | <captured> self |
| app.rb:86:5:86:11 | [post] self | app.rb:24:26:26:5 | <captured> self |
| app.rb:86:5:86:11 | [post] self | app.rb:37:16:42:5 | <captured> self |
| app.rb:86:5:86:11 | [post] self | app.rb:44:53:46:5 | <captured> self |
| app.rb:86:5:86:11 | [post] self | app.rb:56:32:58:5 | <captured> self |
| app.rb:86:5:86:11 | [post] self | app.rb:60:48:62:5 | <captured> self |
| app.rb:86:5:86:11 | [post] self | app.rb:74:11:77:5 | <captured> self |
| app.rb:86:5:86:11 | [post] self | app.rb:79:11:82:5 | <captured> self |
| app.rb:86:5:86:11 | [post] self | app.rb:89:16:92:5 | <captured> self |
| app.rb:86:5:86:11 | [post] self | app.rb:94:15:96:5 | <captured> self |
| app.rb:103:5:103:9 | [post] self | app.rb:2:22:4:5 | <captured> self |
| app.rb:103:5:103:9 | [post] self | app.rb:10:21:13:5 | <captured> self |
| app.rb:103:5:103:9 | [post] self | app.rb:15:23:18:5 | <captured> self |
| app.rb:103:5:103:9 | [post] self | app.rb:24:26:26:5 | <captured> self |
| app.rb:103:5:103:9 | [post] self | app.rb:37:16:42:5 | <captured> self |
| app.rb:103:5:103:9 | [post] self | app.rb:44:53:46:5 | <captured> self |
| app.rb:103:5:103:9 | [post] self | app.rb:56:32:58:5 | <captured> self |
| app.rb:103:5:103:9 | [post] self | app.rb:60:48:62:5 | <captured> self |
| app.rb:103:5:103:9 | [post] self | app.rb:74:11:77:5 | <captured> self |
| app.rb:103:5:103:9 | [post] self | app.rb:79:11:82:5 | <captured> self |
| app.rb:103:5:103:9 | [post] self | app.rb:89:16:92:5 | <captured> self |
| app.rb:103:5:103:9 | [post] self | app.rb:94:15:96:5 | <captured> self |
| app.rb:103:13:103:22 | [post] self | app.rb:2:22:4:5 | <captured> self |
| app.rb:103:13:103:22 | [post] self | app.rb:10:21:13:5 | <captured> self |
| app.rb:103:13:103:22 | [post] self | app.rb:15:23:18:5 | <captured> self |
| app.rb:103:13:103:22 | [post] self | app.rb:24:26:26:5 | <captured> self |
| app.rb:103:13:103:22 | [post] self | app.rb:37:16:42:5 | <captured> self |
| app.rb:103:13:103:22 | [post] self | app.rb:44:53:46:5 | <captured> self |
| app.rb:103:13:103:22 | [post] self | app.rb:56:32:58:5 | <captured> self |
| app.rb:103:13:103:22 | [post] self | app.rb:60:48:62:5 | <captured> self |
| app.rb:103:13:103:22 | [post] self | app.rb:74:11:77:5 | <captured> self |
| app.rb:103:13:103:22 | [post] self | app.rb:79:11:82:5 | <captured> self |
| app.rb:103:13:103:22 | [post] self | app.rb:89:16:92:5 | <captured> self |
| app.rb:103:13:103:22 | [post] self | app.rb:94:15:96:5 | <captured> self |

4
ruby/ql/test/library-tests/frameworks/sinatra/Sinatra.ql
View File

@@ -24,3 +24,7 @@ query predicate filters(Sinatra::Filter filter, string kind) {
query predicate filterPatterns(Sinatra::Filter filter, DataFlow::ExprNode pattern) {
pattern = filter.getPattern()
}
query predicate additionalFlowSteps(DataFlow::Node pred, DataFlow::Node succ) {
any(Sinatra::FilterJumpStep s).step(pred, succ)
}

2
ruby/ql/test/library-tests/frameworks/sinatra/app.rb
View File

@@ -72,7 +72,7 @@ class MyApp < Sinatra::Base
end
get '/' do
@foo = source "foo"
@foo = params["foo"]
erb :index, locals: {foo: @foo}
end