diff --git a/change-notes/1.18/analysis-javascript.md b/change-notes/1.18/analysis-javascript.md index d507351eaa0..a9df3d1e4ed 100644 --- a/change-notes/1.18/analysis-javascript.md +++ b/change-notes/1.18/analysis-javascript.md @@ -45,6 +45,7 @@ | Server-side URL redirect | More true-positive results | This rule now treats header names case-insensitively. | | Uncontrolled command line | More true-positive results | This rule now recognizes indirect command injection through `sh -c` and similar. | | Unused variable | Fewer results | This rule no longer flags class expressions that could be made anonymous. While technically true, these results are not interesting. | +| Unused variable | Renamed | This rule has been renamed to "Unused variable, import, function or class" to reflect the fact that it flags different kinds of unused program elements. | ## Changes to QL libraries diff --git a/javascript/ql/src/Declarations/UnusedVariable.qhelp b/javascript/ql/src/Declarations/UnusedVariable.qhelp index 2fcdfd1b504..457e72362e4 100644 --- a/javascript/ql/src/Declarations/UnusedVariable.qhelp +++ b/javascript/ql/src/Declarations/UnusedVariable.qhelp @@ -7,11 +7,15 @@ Unused local variables make code hard to read and understand. Any computation used to initialize an unused variable is wasted, which may lead to performance problems.
++Similarly, unused imports and unused functions or classes can be confusing. They may even be +a symptom of a bug caused, for example, by an incomplete refactoring. +
Remove the unused variable.
+Remove the unused program element.