hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Adjust tests

Browse Source
This commit is contained in:
Tony Torralba
2021-09-14 13:44:53 +02:00
parent b740cf9664
commit 0640b41f00
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/ql/test/query-tests/security/CWE-807/semmle/tests/ConditionalBypassTest.java
View File

@@ -29,9 +29,9 @@ class ConditionalBypassTest {
if (adminCookie.getValue().equals("false")) // $ hasConditionalBypassTest
login(user, password);
// FALSE POSITIVES: both methods are conditionally executed, but they probably
// GOOD: both methods are conditionally executed, but they probably
// both perform the security-critical action
if (adminCookie.getValue() == "false") { // $ SPURIOUS: $ hasConditionalBypassTest
if (adminCookie.getValue() == "false") { // Safe
login(user, password);
} else {
reCheckAuth(user, password);
@@ -80,8 +80,8 @@ class ConditionalBypassTest {
else {
// do something else
// BAD: login may not happen
return;
}
return;
}
public static void test4(String user, String password) {