hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-18 01:33:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Clarify pruning code.

Browse Source
This commit is contained in:
Mark Shannon
2019-07-24 14:47:46 +01:00
parent 2bdf42388c
commit 05e498dfdc
2 changed files with 6 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
python/ql/src/semmle/python/Pruning.qll
View File

@@ -423,7 +423,7 @@ module Pruner {
reachableEdge(_, bb)
}
Constraint constraintFromTest(SsaVariable var, UnprunedCfgNode node) {
Constraint constraintFromExpr(SsaVariable var, UnprunedCfgNode node) {
py_ssa_use(node, var) and result = TTruthy(true)
or
exists(boolean b |
@@ -435,7 +435,11 @@ module Pruner {
result = TConstrainedByConstant(op, k)
)
or
result = constraintFromTest(var, node.(UnprunedNot).getOperand()).invert()
result = constraintFromExpr(var, node.(UnprunedNot).getOperand()).invert()
}
Constraint constraintFromTest(SsaVariable var, UnprunedCfgNode node) {
result = constraintFromExpr(var, node) and node.isBranch()
}
predicate none_test(UnprunedCompareNode test, SsaVariable var, boolean is) {
@@ -462,8 +466,6 @@ module Pruner {
py_ssa_use(right, var) and
intValue(left.getNode()) = k
)
or
int_test(test.(UnprunedNot).getOperand(), var, op.invert(), k)
}
private predicate constrainingValue(Expr e) {