hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 08:45:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: restrict test to source methods

Browse Source 
Otherwise it finds standard library methods that depend on stdlib internals as to what happens to get extracted. In particular the extractor bump to JDK21 led to MethodHandles being in scope and a new method being found; seems better to avoid considering the standard library at all.
This commit is contained in:
Chris Smowton
2023-10-05 09:54:34 +01:00
parent d56a9f0781
commit 0510b0c825
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/test/library-tests/sensitive-actions/test.expected
View File

@@ -67,5 +67,3 @@ sensitiveDataMethod
| Test.java:37:18:37:31 | aaCryptAccntaa |
| Test.java:39:18:39:33 | aaCryptTrustedaa |
| Test.java:41:18:41:40 | aaCryptRefreshaaTokenaa |
| file:///modules/java.base/java/lang/invoke/MemberName.class:0:0:0:0 | isTrustedFinalField |
| file:///modules/java.base/java/lang/reflect/Field.class:0:0:0:0 | isTrustedFinal |

2
java/ql/test/library-tests/sensitive-actions/test.ql
View File

@@ -9,4 +9,4 @@ query predicate sensitiveVariable(Variable v) {
v.getName().regexpMatch(getCommonSensitiveInfoRegex())
}
query predicate sensitiveDataMethod(SensitiveDataMethod m) { any() }
query predicate sensitiveDataMethod(SensitiveDataMethod m) { m.fromSource() }