hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 09:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: adjust prefix barriers

Browse Source
This commit is contained in:
Jami Cogswell
2024-03-12 20:44:53 -04:00
parent e99cea340b
commit 04d27f2d65
2 changed files with 41 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
java/ql/test/query-tests/security/CWE-552/UrlForwardTest.java
View File

@@ -48,6 +48,14 @@ public class UrlForwardTest extends HttpServlet implements Filter {
return modelAndView;
}
// Not relevant for this query since redirecting instead of forwarding
// This result should be found by the `java/unvalidated-url-redirection` query instead.
@GetMapping("/redirect")
public ModelAndView redirect(String url) {
ModelAndView modelAndView = new ModelAndView("redirect:" + url);
return modelAndView;
}
// `RequestDispatcher` test cases from a Spring `GetMapping` entry point
@GetMapping("/bad5")
public void bad5(String url, HttpServletRequest request, HttpServletResponse response) {
@@ -85,7 +93,7 @@ public class UrlForwardTest extends HttpServlet implements Filter {
@GetMapping("/good1")
public void good1(String url, HttpServletRequest request, HttpServletResponse response) {
try {
request.getRequestDispatcher("/index.jsp?token=" + url).forward(request, response); // $ SPURIOUS: hasUrlForward
request.getRequestDispatcher("/index.jsp?token=" + url).forward(request, response);
} catch (ServletException e) {
e.printStackTrace();
} catch (IOException e) {