hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Add more comments to describe the constant expression hack.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2025-09-25 12:43:57 +01:00
parent 5b5c1de05b
commit 04ce4057e1
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cpp/ql/lib/semmle/code/cpp/controlflow/IRGuards.qll
View File

@@ -97,9 +97,14 @@ module GuardsInput implements SharedGuards::InputSig<Cpp::Location, Instruction,
this.(ConstantInstruction).getValue().toInt() = value and
this.getResultIRType() instanceof IRIntegerType
or
// In order to have an "integer constant" for a switch case
// In order to have an integer constant for a switch case
// we misuse the first instruction (which is always a NoOp instruction)
// as a constant with the switch case's value.
// Even worse, since we need a case range to generate an `TIntRange`
// guard value we must ensure that there exists `ConstantExpr`s whose
// integer value is the end-points. So we let this constant expression
// have both end-point values. Luckily, these `NoOp` instructions do not
// interact with SSA in any way. So this should not break anything.
exists(CaseEdge edge | this = any(SwitchInstruction switch).getSuccessor(edge) |
value = edge.getMaxValue().toInt()
or