hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Review fixes.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2020-11-24 11:31:44 +01:00
parent ebc6c49555
commit 0450489022
20 changed files with 219 additions and 360 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/test/experimental/query-tests/security/CWE-918/options
View File

@@ -1 +1 @@
//semmle-extractor-options: --javac-args -source 11 -target 11 -cp ${testdir}/../../../../stubs/springframework-5.2.3:${testdir}/../../../stubs/javax-ws-rs-api-2.1.1:${testdir}/../../../stubs/apache-httpclient-4.5.12/:${testdir}/../../../../stubs/servlet-api-2.4/
//semmle-extractor-options: --javac-args -source 11 -target 11 -cp ${testdir}/../../../../stubs/springframework-5.2.3:${testdir}/../../../stubs/javax-ws-rs-api-2.1.1:${testdir}/../../../../stubs/apache-http-4.4.13/:${testdir}/../../../../stubs/servlet-api-2.4/

19
java/ql/test/experimental/stubs/apache-httpclient-4.5.12/org/apache/http/client/methods/HttpGet.java
View File

@@ -1,19 +0,0 @@
package org.apache.http.client.methods;
public class HttpGet extends org.apache.http.client.methods.HttpRequestBase {
public static final java.lang.String METHOD_NAME = "GET";
public HttpGet() {
}
public HttpGet(java.net.URI uri) {
}
public HttpGet(java.lang.String uri) {
}
public java.lang.String getMethod() {
return null;
}
}

17
java/ql/test/experimental/stubs/apache-httpclient-4.5.12/org/apache/http/client/methods/HttpRequestBase.java
View File

@@ -1,17 +0,0 @@
package org.apache.http.client.methods;
public abstract class HttpRequestBase {
private java.net.URI uri;
public HttpRequestBase() {
}
public java.net.URI getURI() {
return null;
}
public void setURI(java.net.URI uri) {
}
}

59
java/ql/test/library-tests/frameworks/Networking/Uri.java
View File

@@ -1,59 +0,0 @@
import java.io.IOException;
import java.io.InputStream;
import java.net.Proxy;
import java.net.SocketAddress;
import java.net.URI;
import java.net.URL;
import java.net.URLConnection;
import java.net.URLStreamHandler;
import java.net.Proxy.Type;
public class Uri {
public static void main(String[] args) throws Exception {
// URI(String str)
URI uri = new URI("uri1");
// URI(String scheme, String ssp, String fragment)
URI ur2 = new URI("http", "ssp", "fragement");
// URI(String scheme, String userInfo, String host, int port, String path,
// String query, String fragment)
URI uri3 = new URI("http", "userinfo", "host", 1, "path", "query", "fragment");
// URI(String scheme, String host, String path, String fragment)
URI uri4 = new URI("http", "host", "path", "fragment");
// URI(String scheme, String authority, String path, String query, String
// fragment)
URI uri5 = new URI("http", "authority", "path", "query", "fragment");
// URI.create​(String str)
URI uri6 = URI.create("http://foo.com/");
// URL(String spec)
URL url1 = new URL("spec");
// URL(String protocol, String host, int port, String file)
URL url2 = new URL("http", "host", 1, "file");
// URL(String protocol, String host, String file)
URL url3 = new URL("http", "host", "file");
// URL(URL context, String spec)
URL url4 = new URL(url3, "http");
// URL(String protocol, String host, int port, String file, URLStreamHandler
// handler)
URL url5 = new URL("http", "host", 1, "file", new Helper());
// URL(URL context, String spec, URLStreamHandler handler)
URL url6 = new URL(url3, "spec", new Helper());
URLConnection c1 = url1.openConnection();
SocketAddress sa = new SocketAddress() {
};
URLConnection c2 = url1.openConnection(new Proxy(Type.HTTP, sa));
InputStream c3 = url1.openStream();
}
}
class Helper extends URLStreamHandler {
@Override
protected URLConnection openConnection(URL arg0) throws IOException {
return null;
}
}

2
java/ql/test/library-tests/frameworks/Networking/openConnection.expected
View File

@@ -1,2 +0,0 @@
| Uri.java:46:28:46:48 | openConnection(...) |
| Uri.java:49:28:49:72 | openConnection(...) |

5
java/ql/test/library-tests/frameworks/Networking/openConnection.ql
View File

@@ -1,5 +0,0 @@
import java
import semmle.code.java.frameworks.Networking
from UrlOpenConnectionMethod m
select m.getAReference()

1
java/ql/test/library-tests/frameworks/Networking/openStream.expected
View File

@@ -1 +0,0 @@
| Uri.java:50:26:50:42 | openStream(...) |

5
java/ql/test/library-tests/frameworks/Networking/openStream.ql
View File

@@ -1,5 +0,0 @@
import java
import semmle.code.java.frameworks.Networking
from UrlOpenStreamMethod m
select m.getAReference()

6
java/ql/test/library-tests/frameworks/Networking/uri.expected
View File

@@ -1,6 +0,0 @@
| Uri.java:14:19:14:33 | new URI(...) | Uri.java:14:27:14:32 | "uri1" |
| Uri.java:17:19:17:53 | new URI(...) | Uri.java:17:35:17:39 | "ssp" |
| Uri.java:21:20:21:86 | new URI(...) | Uri.java:21:48:21:53 | "host" |
| Uri.java:23:20:23:62 | new URI(...) | Uri.java:23:36:23:41 | "host" |
| Uri.java:26:20:26:76 | new URI(...) | Uri.java:26:36:26:46 | "authority" |
| Uri.java:29:20:29:48 | create(...) | Uri.java:29:31:29:47 | "http://foo.com/" |

5
java/ql/test/library-tests/frameworks/Networking/uri.ql
View File

@@ -1,5 +0,0 @@
import java
import semmle.code.java.frameworks.Networking
from UriCreation c
select c, c.getHostArg()

4
java/ql/test/library-tests/frameworks/Networking/url.expected
View File

@@ -1,4 +0,0 @@
| Uri.java:32:20:32:34 | new URL(...) | Uri.java:32:28:32:33 | "spec" |
| Uri.java:34:20:34:53 | new URL(...) | Uri.java:34:36:34:41 | "host" |
| Uri.java:36:20:36:50 | new URL(...) | Uri.java:36:36:36:41 | "host" |
| Uri.java:41:20:41:67 | new URL(...) | Uri.java:41:36:41:41 | "host" |

5
java/ql/test/library-tests/frameworks/Networking/url.ql
View File

@@ -1,5 +0,0 @@
import java
import semmle.code.java.frameworks.Networking
from UrlConstructor c
select c, c.getHostArg()