hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-22 23:35:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Adjust alert message

Browse Source
This commit is contained in:
Owen Mansel-Chan
2025-03-25 11:50:42 +00:00
parent fea3d10b97
commit 042fe07494
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/ql/src/Performance/StringReplaceAllWithNonRegex.ql
View File

@@ -11,9 +11,11 @@
import java
from StringReplaceAllCall replaceAllCall
from StringReplaceAllCall replaceAllCall, StringLiteral firstArg
where
firstArg = replaceAllCall.getArgument(0) and
//only contains characters that could be a simple string
replaceAllCall.getArgument(0).(StringLiteral).getValue().regexpMatch("^[a-zA-Z0-9]+$")
firstArg.getValue().regexpMatch("^[a-zA-Z0-9]+$")
select replaceAllCall,
"Call to 'replaceAll' uses an argument comprised of plain string characters only."
"This call to 'replaceAll' should be a call `replace` as its $@ is not a regular expression.",
firstArg, "first argument"

2
java/ql/test/query-tests/StringReplaceAllWithNonRegex/StringReplaceAllWithNonRegex.expected
View File

@@ -1 +1 @@
| Test.java:4:14:4:36 | replaceAll(...) | Call to 'replaceAll' uses an argument comprised of plain string characters only. |
| Test.java:4:14:4:36 | replaceAll(...) | This call to 'replaceAll' should be a call `replace` as its $@ is not a regular expression. | Test.java:4:28:4:30 | "t" | first argument |