hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Restrict pipe detection to calls with 1-2 arguments

Browse Source
This commit is contained in:
Napalys Klicius
2025-05-20 14:45:51 +02:00
parent 30f2815503
commit 03d1f9a7d3
3 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/test/query-tests/Quality/UnhandledStreamPipe/test.expected
View File

@@ -9,5 +9,3 @@
| test.js:116:5:116:21 | stream.pipe(dest) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
| test.js:125:5:125:26 | getStre ... e(dest) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
| test.js:143:5:143:62 | stream. ... itable) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
| test.js:163:5:163:20 | notStream.pipe() | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |
| test.js:167:5:167:36 | notStre ... , arg3) | Stream pipe without error handling on the source stream. Errors won't propagate downstream and may be silently dropped. |

4
javascript/ql/test/query-tests/Quality/UnhandledStreamPipe/test.js
View File

@@ -160,10 +160,10 @@ function test() {
}
{ // Calling custom pipe method with no arguments
const notStream = getNotAStream();
notStream.pipe(); // $SPURIOUS:Alert
notStream.pipe();
}
{ // Calling custom pipe method with more then 2 arguments
const notStream = getNotAStream();
notStream.pipe(arg1, arg2, arg3); // $SPURIOUS:Alert
notStream.pipe(arg1, arg2, arg3);
}
}