hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

JS: model React's getDerivedStateFromError

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2019-11-20 12:57:35 +01:00
parent 53576a4781
commit 03c83c9c9d
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
javascript/ql/src/semmle/javascript/frameworks/React.qll
View File

@@ -136,7 +136,12 @@ abstract class ReactComponent extends ASTNode {
result = arg0 result = arg0
) )
or or
result.flowsToExpr(getStaticMethod("getDerivedStateFromProps").getAReturnedExpr()) exists(string staticMember |
staticMember = "getDerivedStateFromProps" or
staticMember = "getDerivedStateFromError"
|
result.flowsToExpr(getStaticMethod(staticMember).getAReturnedExpr())
)
or or
// shouldComponentUpdate: (nextProps, nextState) // shouldComponentUpdate: (nextProps, nextState)
result = DataFlow::parameterNode(getInstanceMethod("shouldComponentUpdate").getParameter(1)) result = DataFlow::parameterNode(getInstanceMethod("shouldComponentUpdate").getParameter(1))

12
javascript/ql/test/query-tests/React/UnusedOrUndefinedStateProperty/issue-2389.reduced.js Normal file
View File

@@ -0,0 +1,12 @@
import React from "react"
class C extends React.Component {
static getDerivedStateFromError(error) {
return { error }
}
render() {
this.state.error;
}
}