hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Add more tests for cs/useless-cast-to-self

Browse Source
This commit is contained in:
Tom Hvitved
2022-04-06 09:36:59 +02:00
parent ccd7bb5e70
commit 02b11084bc
3 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
csharp/ql/test/query-tests/Language Abuse/UselessCastToSelf/UselessCastToSelf.cs
View File

@@ -1,4 +1,5 @@
using System;
using System.Linq.Expressions;
class Test
{
@@ -8,6 +9,8 @@ class Test
var bad1 = (int)1;
var bad2 = (Test)this;
var bad3 = this as Test;
func = (Func<int, int?>)(x => x); // MISSING
exprFunc = (Expression<Func<int, int?>>)(x => x);
// GOOD
var good1 = (object)1;
@@ -17,6 +20,8 @@ class Test
var good5 = (Action<int>)(x => { });
var good6 = (Action<int>)(delegate (int x) { });
var good7 = (Action<int>)((int x) => { });
func = x => x;
exprFunc = x => x;
}
enum Enum
@@ -27,4 +32,7 @@ class Test
D = 9 | (32 << A),
E = 9 | (32 << (int)A) // BAD
}
private Func<int, int?> func;
private Expression<Func<int, int?>> exprFunc;
}

11
csharp/ql/test/query-tests/Language Abuse/UselessCastToSelf/UselessCastToSelf.expected
View File

@@ -1,5 +1,6 @@
| UselessCastToSelf.cs:8:20:8:25 | (...) ... | This cast is redundant because the expression already has type Int32. |
| UselessCastToSelf.cs:9:20:9:29 | (...) ... | This cast is redundant because the expression already has type Test. |
| UselessCastToSelf.cs:10:20:10:31 | ... as ... | This cast is redundant because the expression already has type Test. |
| UselessCastToSelf.cs:26:17:26:22 | (...) ... | This cast is redundant because the expression already has type Int32. |
| UselessCastToSelf.cs:28:24:28:29 | (...) ... | This cast is redundant because the expression already has type Int32. |
| UselessCastToSelf.cs:9:20:9:25 | (...) ... | This cast is redundant because the expression already has type Int32. |
| UselessCastToSelf.cs:10:20:10:29 | (...) ... | This cast is redundant because the expression already has type Test. |
| UselessCastToSelf.cs:11:20:11:31 | ... as ... | This cast is redundant because the expression already has type Test. |
| UselessCastToSelf.cs:13:20:13:56 | (...) ... | This cast is redundant because the expression already has type Expression<Func<Int32,Nullable<Int32>>>. |
| UselessCastToSelf.cs:31:17:31:22 | (...) ... | This cast is redundant because the expression already has type Int32. |
| UselessCastToSelf.cs:33:24:33:29 | (...) ... | This cast is redundant because the expression already has type Int32. |

2
csharp/ql/test/query-tests/Language Abuse/UselessCastToSelf/options Normal file
View File

@@ -0,0 +1,2 @@
semmle-extractor-options: /nostdlib /noconfig
semmle-extractor-options: --load-sources-from-project:${testdir}/../../../resources/stubs/_frameworks/Microsoft.NETCore.App/Microsoft.NETCore.App.csproj