hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix StoredXssTypeTracking example query

Browse Source
This commit is contained in:
Asger Feldthaus
2021-08-11 12:28:54 +02:00
parent cb0075f15a
commit 020d65befc
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
javascript/ql/examples/queries/dataflow/StoredXss/StoredXssTypeTracking.ql
View File

@@ -9,7 +9,6 @@
*/ */
import javascript import javascript
import DataFlow
import semmle.javascript.security.dataflow.StoredXssQuery import semmle.javascript.security.dataflow.StoredXssQuery
import DataFlow::PathGraph import DataFlow::PathGraph
@@ -18,7 +17,7 @@ import DataFlow::PathGraph
*/ */
DataFlow::SourceNode mysqlConnection(DataFlow::TypeTracker t) { DataFlow::SourceNode mysqlConnection(DataFlow::TypeTracker t) {
t.start() and t.start() and
result = moduleImport("mysql").getAMemberCall("createConnection") result = DataFlow::moduleImport("mysql").getAMemberCall("createConnection")
or or
exists(DataFlow::TypeTracker t2 | result = mysqlConnection(t2).track(t2, t)) exists(DataFlow::TypeTracker t2 | result = mysqlConnection(t2).track(t2, t))
} }
@@ -46,6 +45,6 @@ class MysqlSource extends Source {
MysqlSource() { this = mysqlConnection().getAMethodCall("query").getCallback(1).getParameter(1) } MysqlSource() { this = mysqlConnection().getAMethodCall("query").getCallback(1).getParameter(1) }
} }
from Configuration cfg, PathNode source, PathNode sink from Configuration cfg, DataFlow::PathNode source, DataFlow::PathNode sink
where cfg.hasFlowPath(source, sink) where cfg.hasFlowPath(source, sink)
select sink.getNode(), source, sink, "Stored XSS from $@.", source.getNode(), "database value." select sink.getNode(), source, sink, "Stored XSS from $@.", source.getNode(), "database value."