hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

JavaScript: Use new API in NoSQL models.

Browse Source
This commit is contained in:
Max Schaefer
2020-10-06 09:45:03 +01:00
parent 8277d5c08f
commit 0109805ab0
2 changed files with 8 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
javascript/ql/src/semmle/javascript/ApiGraphs.qll
View File

@@ -312,9 +312,6 @@ module API {
/** Gets a data-flow node that defines this entry point. */
abstract DataFlow::Node getARhs();
/** Gets an API-graph node for this entry point. */
API::Node getNode() { result = root().getASuccessor(this) }
}
/**

60
javascript/ql/src/semmle/javascript/frameworks/NoSQL.qll
View File

@@ -48,20 +48,6 @@ private module MongoDB {
not result.getAnImmediateUse().(DataFlow::ParameterNode).getName() = "client" // mongodb v3 provides a `Mongoclient` here
}
/**
* A collection based on the type `mongodb.Collection`.
*
* Note that this also covers `mongoose` models since they are subtypes
* of `mongodb.Collection`.
*/
private class TypedMongoCollection extends API::EntryPoint {
TypedMongoCollection() { this = "TypedMongoCollection" }
override DataFlow::SourceNode getAUse() { result.hasUnderlyingType("mongodb", "Collection") }
override DataFlow::Node getARhs() { none() }
}
/** Gets a data flow node referring to a MongoDB collection. */
private API::Node getACollection() {
// A collection resulting from calling `Db.collection(...)`.
@@ -71,7 +57,8 @@ private module MongoDB {
result = collection.getParameter(1).getParameter(0)
)
or
result = any(TypedMongoCollection c).getNode()
// note that this also covers `mongoose` models since they are subtypes of `mongodb.Collection`
result = API::Node::ofType("mongodb", "Collection")
}
/** A call to a MongoDB query method. */
@@ -225,17 +212,6 @@ private module Mongoose {
}
}
/**
* A Mongoose collection based on the type `mongoose.Model`.
*/
private class TypedMongooseModel extends API::EntryPoint {
TypedMongooseModel() { this = "TypedMongooseModel" }
override DataFlow::SourceNode getAUse() { result.hasUnderlyingType("mongoose", "Model") }
override DataFlow::Node getARhs() { none() }
}
/**
* Gets a API-graph node referring to a Mongoose Model object.
*/
@@ -247,7 +223,7 @@ private module Mongoose {
result = conn.getMember("models").getAMember()
)
or
result = any(TypedMongooseModel c).getNode()
result = API::Node::ofType("mongoose", "Model")
}
/**
@@ -341,24 +317,13 @@ private module Mongoose {
override API::Node getQueryArgument() { result = this.getParameter(2) }
}
/**
* A Mongoose query.
*/
private class TypedMongooseQuery extends API::EntryPoint {
TypedMongooseQuery() { this = "TypedMongooseQuery" }
override DataFlow::SourceNode getAUse() { result.hasUnderlyingType("mongoose", "Query") }
override DataFlow::Node getARhs() { none() }
}
/**
* Gets a data flow node referring to a Mongoose query object.
*/
API::Node getAMongooseQuery() {
result = any(MongooseFunction f).getQueryReturn()
or
result = any(TypedMongooseQuery c).getNode()
result = API::Node::ofType("mongoose", "Query")
or
result =
getAMongooseQuery()
@@ -560,23 +525,14 @@ private module Mongoose {
}
}
/**
* A Mongoose document.
*/
private class TypedMongooseDocument extends API::EntryPoint {
TypedMongooseDocument() { this = "TypedMongooseDocument" }
override DataFlow::SourceNode getAUse() { result.hasUnderlyingType("mongoose", "Document") }
override DataFlow::Node getARhs() { none() }
}
/**
* Gets a data flow node referring to a Mongoose Document object.
*/
private API::Node getAMongooseDocument() {
result instanceof RetrievedDocument or
result = any(TypedMongooseDocument c).getNode() or
result instanceof RetrievedDocument
or
result = API::Node::ofType("mongoose", "Document")
or
result =
getAMongooseDocument()
.getMember(any(string name | MethodSignatures::returnsDocument(name)))