diff --git a/javascript/ql/src/semmle/javascript/frameworks/ClientRequests.qll b/javascript/ql/src/semmle/javascript/frameworks/ClientRequests.qll index 485c2f12f97..e7beb9f2258 100644 --- a/javascript/ql/src/semmle/javascript/frameworks/ClientRequests.qll +++ b/javascript/ql/src/semmle/javascript/frameworks/ClientRequests.qll @@ -84,8 +84,6 @@ private string urlPropertyName() { * A model of a URL request made using the `request` library. */ private class RequestUrlRequest extends ClientRequest::Range { - DataFlow::Node url; - RequestUrlRequest() { exists(string moduleName, DataFlow::SourceNode callee | this = callee.getACall() | ( diff --git a/javascript/ql/src/semmle/javascript/frameworks/CryptoLibraries.qll b/javascript/ql/src/semmle/javascript/frameworks/CryptoLibraries.qll index 7cfee868a51..cc239efd570 100644 --- a/javascript/ql/src/semmle/javascript/frameworks/CryptoLibraries.qll +++ b/javascript/ql/src/semmle/javascript/frameworks/CryptoLibraries.qll @@ -329,8 +329,6 @@ private module NodeJSCrypto { } private class Apply extends CryptographicOperation, MethodCallExpr { - Expr input; - InstantiatedAlgorithm instantiation; Apply() { diff --git a/javascript/ql/src/semmle/javascript/frameworks/Electron.qll b/javascript/ql/src/semmle/javascript/frameworks/Electron.qll index aa0ca16eacd..84373662a24 100644 --- a/javascript/ql/src/semmle/javascript/frameworks/Electron.qll +++ b/javascript/ql/src/semmle/javascript/frameworks/Electron.qll @@ -256,7 +256,10 @@ module Electron { private class IPCAdditionalFlowStep extends DataFlow::AdditionalFlowStep { IPCAdditionalFlowStep() { ipcFlowStep(this, _) } - override predicate step(DataFlow::Node pred, DataFlow::Node succ) { ipcFlowStep(pred, succ) } + override predicate step(DataFlow::Node pred, DataFlow::Node succ) { + pred = this and + ipcFlowStep(pred, succ) + } } }