hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 12:15:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #611 from aschackmull/java/usessl-fp-fix

Browse Source 
Java: Fix FP in `UseSSL.ql`.
This commit is contained in:
yh-semmle
2018-12-04 19:31:53 -05:00
committed by GitHub
parent d05b11f00d d3fcfb0957
commit 00779c518c
4 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
java/ql/test/query-tests/security/CWE-311/CWE-319/Test.java Normal file
View File

@@ -0,0 +1,14 @@
import java.net.HttpURLConnection;
import javax.net.ssl.HttpsURLConnection;
import java.io.*;
class Test {
public void m1(HttpURLConnection connection) {
InputStream input;
if (connection instanceof HttpsURLConnection) {
input = connection.getInputStream(); // OK
} else {
input = connection.getInputStream(); // BAD
}
}
}

1
java/ql/test/query-tests/security/CWE-311/CWE-319/UseSSL.expected Normal file
View File

@@ -0,0 +1 @@
| Test.java:11:15:11:41 | getInputStream(...) | Stream using vulnerable non-SSL connection. |

1
java/ql/test/query-tests/security/CWE-311/CWE-319/UseSSL.qlref Normal file
View File

@@ -0,0 +1 @@
Security/CWE/CWE-319/UseSSL.ql