From 1b5de3ff9a11ceb4b009bd30409ef2cbdfcd0f6c Mon Sep 17 00:00:00 2001 From: Kristen Newbury Date: Wed, 30 Jul 2025 11:56:28 -0400 Subject: [PATCH] Clean code for TaintFlowDebugging.ql --- codeql-sqlite/TaintFlowDebugging.ql | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/codeql-sqlite/TaintFlowDebugging.ql b/codeql-sqlite/TaintFlowDebugging.ql index 37e1ab6..a854532 100644 --- a/codeql-sqlite/TaintFlowDebugging.ql +++ b/codeql-sqlite/TaintFlowDebugging.ql @@ -8,6 +8,7 @@ import java import semmle.code.java.dataflow.FlowSources +import semmle.code.java.dataflow.TaintTracking class ReadLineSource extends Source { ReadLineSource() { this.getMethod().hasQualifiedName("java.io", "Console", "readLine") } @@ -19,13 +20,6 @@ class Sink extends MethodCall { Sink() { this.getMethod().hasQualifiedName("java.sql", "Statement", "executeUpdate") } } -// from Sink s -// select s, "" -// from MethodCall mc -// where mc.getMethod().getName() = "readLine" -// select mc, mc.getMethod().getQualifiedName() -import semmle.code.java.dataflow.TaintTracking - module MyFlowConfiguration implements DataFlow::ConfigSig { predicate isSource(DataFlow::Node source) { //exists(Source s | source.asExpr() = s) @@ -33,7 +27,6 @@ module MyFlowConfiguration implements DataFlow::ConfigSig { } predicate isSink(DataFlow::Node sink) { - //sink.asExpr() instanceof Sink exists(Sink sink2 | sink.asExpr() = sink2.getArgument(_)) //any() }